Skip to content

Moved icon replacement code to partial #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Moved icon replacement code to partial #266

merged 1 commit into from
May 28, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented May 27, 2025 •
edited
Loading

Proposed changes

Motivated by the fact that the replacement code can be used outside of just _default/docs.html, particularly banners or nav headers.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this May 27, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner May 27, 2025 18:50
@lamATnginx lamATnginx added the enhancement New feature or request label May 27, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/266/

danielledeleo
danielledeleo approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@danielledeleo danielledeleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@lamATnginx lamATnginx merged commit d474cc9 into main May 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielledeleo danielledeleo danielledeleo approved these changes

@nginx-jack nginx-jack nginx-jack approved these changes

Assignees

@lamATnginx lamATnginx

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lamATnginx @danielledeleo @nginx-jack